Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gumbo-parser: deprecate #172148

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

branchvincent
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Archived Feb 15 2023: https://github.com/google/gumbo-parser

@github-actions github-actions bot added the formula deprecated Formula deprecated label May 20, 2024
@chenrui333 chenrui333 added the CI-no-bottles Merge without publishing bottles label May 20, 2024
@bevanjkay
Copy link
Member

brew uses gumbo-parser --eval-all --include-build --include-test                            
mupdf

@branchvincent branchvincent marked this pull request as draft May 20, 2024 19:03
@SMillerDev
Copy link
Member

I think we'll have to vendor it there, since they don't seem to accept that it's unsupported.

@branchvincent
Copy link
Member Author

Done in #172418

@p-linnane p-linnane marked this pull request as ready for review May 22, 2024 20:25
@BrewTestBot BrewTestBot added this pull request to the merge queue May 23, 2024
Merged via the queue into Homebrew:master with commit 62d6746 May 23, 2024
23 checks passed
@branchvincent branchvincent deleted the gumbo-parser branch May 23, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles formula deprecated Formula deprecated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants